reorganize tests - #60
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on December 31
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| td(y ~ 1, method = "chow-lin-minrss-ecotrim", truncated.rho = -1), | ||
| NA # NA means we expect no error, or we might expect a specific error | ||
| ) | ||
| }) |
There was a problem hiding this comment.
Bug: Clarify Chow-Lin Intercept-Only Edge Case Behavior
The test for chow-lin with an intercept-only model (y ~ 1) asserts no error using expect_error(..., NA). The accompanying comment, however, incorrectly suggests ambiguity about this expectation, stating an error might also be valid. This creates a misleading comment and unclear test logic. Clarifying the intended behavior for this edge case is important, as Chow-Lin methods typically require indicator variables.
| start = 1975, frequency = 1 | ||
| ) | ||
|
|
||
| cat("sales.a matches reconstructed:", all.equal(sales.a, sales_reconstructed), "\n") |
There was a problem hiding this comment.
Bug: Mismatched Time Range Breaks Dataset Equality Check
The verification step compares the full sales.a dataset with sales_reconstructed. However, sales_reconstructed is a hardcoded subset (1975-2010), while sales.a is the complete dataset. This difference in time periods and length means the all.equal comparison will always fail.
1 participant
Note
Replaces the old CI-only monolithic tests with a structured testthat suite using inline fixtures, adds generator scripts, and introduces comprehensive method and regression tests with skip_on_cran.
tests/test-all.Rwith focused testthat files:test-aggregation.R,test-conversion-types.R,test-methods-chow-lin.R,test-methods-denton.R,test-methods-other.R,test-numerical-regression.R(all useskip_on_cran()where heavy).tests/testthat/helper-fixtures.R(inlineimports.mplus reference listsreference_y2q,reference_q2m).tests/testthat/test_output.Randtests/testthat/test_ta.R.noinst/README.md,extract_test_data.R, andgenerate_test_code.Rto generate and maintain inline test data/fixtures from.RDatasources.Written by Cursor Bugbot for commit 3717188. This will update automatically on new commits. Configure here.